Skip to content

ReadMe Installation fixes#9

Merged
CatarinaGamboa merged 4 commits intomainfrom
installation-doc-fixes
Apr 18, 2025
Merged

ReadMe Installation fixes#9
CatarinaGamboa merged 4 commits intomainfrom
installation-doc-fixes

Conversation

@Pichers
Copy link
Collaborator

@Pichers Pichers commented Apr 16, 2025

Description

[Corrected the "git clone" and "cd" commands]

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring

@Pichers
Copy link
Collaborator Author

Pichers commented Apr 16, 2025

Had to change "cd latte" to "cd latte/latte-umbrella" as the pom.xml is in that sub folder

@alcides
Copy link
Collaborator

alcides commented Apr 16, 2025

latte-umbrella is a legacy name that comes from liquidjava-umbrella that held several projects. Maybe we can rename latte-umbrella to something else. Maybe simply latte?

@CatarinaGamboa
Copy link
Collaborator

I think changing latte-umbrella to latte is a good idea, can you make that change in this PR @Pichers ?

@Pichers
Copy link
Collaborator Author

Pichers commented Apr 17, 2025

On it

@Pichers
Copy link
Collaborator Author

Pichers commented Apr 17, 2025

Done (kind of)
There are still 3 commands mentioned on the ReadMe, that I'm not 100% sure how to adapt

@CatarinaGamboa
Copy link
Collaborator

CatarinaGamboa commented Apr 17, 2025

I've changed more folders that were using latte-umbrella and whose names collided with latte.
(you can just pull this branch)
@Pichers can you put here which commands you are unsure about?

Also, did you test locally?
We should handle #10 next

@CatarinaGamboa CatarinaGamboa merged commit 45a115f into main Apr 18, 2025
1 check passed
@CatarinaGamboa
Copy link
Collaborator

I've merged this branch, we can discuss those changes in the readme in a followup pr

@Pichers Pichers deleted the installation-doc-fixes branch May 21, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants