feat: public-pools-strategy-manager Dead Man's Switch#55
feat: public-pools-strategy-manager Dead Man's Switch#55MarvinJanssen wants to merge 2 commits intomainnetfrom
Conversation
MarvinJanssen
requested review from
fiftyeightandeight and
friedger
as code owners
friedger
left a comment
friedger
left a comment
There was a problem hiding this comment.
Looks good.
Unit tests would be nice
And a lip
| (define-constant err-unauthorised (err u3000)) | ||
| (define-constant err-still-alive (err u3001)) | ||
|
|
||
| (define-constant dms-activation-period u12960) ;; ~90 days |
There was a problem hiding this comment.
one cycle is already bad. So 2100 bitcoin blocks?
There was a problem hiding this comment.
Sure we can do that, but then a manager must be sure to send a keep-alive each cycle if there are no changes. The theory of the DMS was so that people can always get the underlying STX of their LiSTX back into the vault in case the managers go missing.
There was a problem hiding this comment.
Pool manager has to extend if nobody else does it for us
|
|
||
| ;; Dead Man's switch | ||
|
|
||
| (define-read-only (dms-active) |
There was a problem hiding this comment.
dms-active sounds like the dms was pressed. Better "dms-inactive"?
There was a problem hiding this comment.
Perhaps dms-available? I called it "active" because it indicates the DMS "can be pressed".
There was a problem hiding this comment.
Probably, I don't understandthe term DMS not properly. It indicates that the manager was not active, correct?
Go with whatever you like.
| @@ -27,3 +28,7 @@ requirements = [ | |||
| [contracts.lip007] | |||
| path = "contracts/proposals/lip007.clar" | |||
|
Ok if you think this method is the way to go then I can add tests and a LIP to activate it. I do not think a frontend is needed for the DMS at this time. It is just to ensure tokens can never get stuck in the public pool members. |
3 participants
No description provided.