Skip to content

Navbar gatsby#19

Open
eduardor2m wants to merge 9 commits intomainfrom
navibar-gatsby
Open

Navbar gatsby#19
eduardor2m wants to merge 9 commits intomainfrom
navibar-gatsby

Conversation

@eduardor2m
Copy link
Contributor

@eduardor2m eduardor2m commented Feb 1, 2022

Related Issue

  • Create the navbar

Proposed Changes

  • stylization with bootstrap
  • using svg

Additional Info

  • any additional information or context

Checklist

  • Tests
  • Translations
  • Documentation

Screenshots

image

image

image

Original Updated
original screenshot updated screenshot

@eduardor2m eduardor2m added the enhancement New feature or request label Feb 1, 2022
@eduardor2m eduardor2m self-assigned this Feb 1, 2022
@eduardor2m eduardor2m temporarily deployed to cuc-site February 1, 2022 07:56 Inactive
@eduardor2m eduardor2m temporarily deployed to cuc-site February 1, 2022 16:36 Inactive
Copy link
Member

@Manuel-Antunes Manuel-Antunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my issues

@@ -0,0 +1,5 @@
/* eslint-disable @typescript-eslint/no-explicit-any */
declare module '*.svg' {
const content: any;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't like any types...

.big-fragments-group {
left: 75%;
top: -30%;
/* top: -30%; */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this field again

function IndexPage() {
return (
<Box width="100%">
<Box w="100vw" h="100vh" bgColor="#0B132B">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, don't use vw or vh here

Copy link

@leticiabsduarte leticiabsduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a mobile version being made, but good work

@eduardor2m eduardor2m temporarily deployed to cuc-site February 2, 2022 15:15 Inactive
@netlify
Copy link

netlify bot commented Feb 5, 2022

❌ Deploy Preview for lucid-shirley-299a0a failed.

🔨 Explore the source changes: 909e10f

🔍 Inspect the deploy log: https://app.netlify.com/sites/lucid-shirley-299a0a/deploys/620561644a74bb000813edac

Copy link
Member

@Manuel-Antunes Manuel-Antunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all SCSS files, use styled components

@sandenson sandenson changed the title Navibar gatsby Navbar gatsby Feb 9, 2022
Copy link
Member

@Manuel-Antunes Manuel-Antunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my issues

}
`;

const ContainerStyled = styled(Container)`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not change container to fluid, add flex using bootstrap class instead of use styled components?

box-shadow: 0px 0px 12px #cf721c;
`;

export default Navbar;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All classes can be overwriten using some bootstrap classes

export const Main: React.FC = ({ children }) => {
const href = useMemo(() => (window ? window.location.href : ''), [window]);

const path = href.slice(href.lastIndexOf('/') + 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add all this logics in memo, we uses memo to optimize updatable variables, so, if we need to change things use the memo hook, click here for more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants