Fix TypeScript build errors in PreviewBadge component #1174

Copilot · 2025-10-26T13:40:20Z

Fix TypeScript Build Errors

Resolves all remaining TypeScript compilation errors preventing the build from completing.

Changes Made

Type Annotations in PreviewBadge.tsx

Fixed branchInfo?.name null checks in 3 locations (lines 882, 952, 1003)
Added type annotations to all remaining functions with implicit any parameters:
- handleApprovePR, handleRequestChanges, handleMarkReadyForReview
- checkPermissions, setupCommentAutoRefresh, setupWorkflowAutoRefresh
- handleCommentToggle, truncateDescription, convertGitHubNotationToLinks
- processMarkdownContent, convertGitHubNotationToHtml
- sanitizeHtmlContent, truncateComment, formatDate
- handleBadgeClick, handleBadgeToggle, truncateTitle
Fixed error catch blocks to use error: any type annotation (4 locations)
Fixed commentSubmissionStatus to use string values instead of objects
Updated PRInfo interface to include optional properties: head.sha, user.html_url
Fixed pr.id to pr.number for correct key usage
Fixed MDEditor prop visibleDragBar to visibleDragbar
Simplified comment submission status display to only handle string values

New Methods in githubService.ts

requestPullRequestChanges() - Request changes on a PR (renamed from requestChanges)
markPullRequestReadyForReview() - Mark a draft PR as ready for review
checkCommentPermissions() - Check if user can comment on issues/PRs
checkPullRequestMergePermissions() - Check if user can merge PRs
checkPullRequestReviewPermissions() - Check if user can review PRs
checkRepositoryWritePermissions() - Check if user has write access
createPullRequestComment() - Create a comment on a PR

New Methods in githubActionsService.ts

checkWorkflowTriggerPermissions() - Check if user can trigger workflows
checkWorkflowApprovalPermissions() - Check if user can approve workflow runs

All methods properly implement error handling and logging.

Original prompt

This section details on the original issue you should resolve

<issue_title>fix PR 1411 build error</issue_title>
<issue_description>#1141 has build errors.
build off branch copilot/continue-typescript-migration
Please iterate fixing until the build successfully works.

Current issue:

2s
17s
0s
2s
0s
0s
0s
3s
14s
1s
0s
2s
1m 8s
Run echo "Building with PUBLIC_URL: /sgex/copilot-continue-typescript-migration/"
Building with PUBLIC_URL: /sgex/copilot-continue-typescript-migration/
Building with REACT_APP_GITHUB_REF_NAME: copilot/continue-typescript-migration

> sgex-workbench@1.0.0 prebuild
> echo 'Skipping prebuild due to TypeScript errors'

Skipping prebuild due to TypeScript errors

> sgex-workbench@1.0.0 build
> npm run configure:repo && craco build


> sgex-workbench@1.0.0 configure:repo
> node scripts/configure-repository.js

🔧 Configuring repository settings for build...
✅ Repository consistency verified: litlfred/sgex
✅ Repository configuration set from package.json:
   Owner: litlfred
   Name: sgex
   Full: litlfred/sgex
   Env file: .env
✅ Updated 404.html with repository: litlfred/sgex
✨ Repository configuration complete!
Creating an optimized production build...
Failed to compile.

TS2345: Argument of type 'IssueTemplate[]' is not assignable to parameter of type 'SetStateAction<TemplateType[]>'.
  Type 'IssueTemplate[]' is not assignable to type 'TemplateType[]'.
    Type 'IssueTemplate' is missing the following properties from type 'TemplateType': type, fields
    76 |       setLoading(true);
    77 |       const fetchedTemplates = await bugReportService.getTemplates();
  > 78 |       setTemplates(fetchedTemplates);
       |                    ^^^^^^^^^^^^^^^^
    79 |     } catch (err) {
    80 |       console.error('Failed to load templates:', err);
    81 |       setError('Failed to load bug report templates. Using defaults.');


npm notice
npm notice New major version of npm available! 10.8.2 -> 11.6.2
npm notice Changelog: https://github.com/npm/cli/releases/tag/v11.6.2
npm notice To update run: npm install -g npm@11.6.2
npm notice
```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
<comment_new><author>@litlfred</author><body>
Build issues wer only partially addressed. Current errors 
fix build error. TS7006: Parameter 'comment' implicitly has an 'any' type.
425 | };
426 |

427 | const getCommentViewers = (comment, allComments) => {
| ^^^^^^^
428 | const viewers = new Set();
429 |
430 | // Extract mentions from the comment body</body></comment_new>
</comments>

Fixes fix PR 1411 build error #1157

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: litlfred <662242+litlfred@users.noreply.github.com>

github-actions · 2025-10-26T14:46:01Z

🚀 Deployment Status: Building 🔵

🔗 Quick Actions:

📊 Watch build progress
🔄 Restart build

📝 Recent Change Summary

Latest commit: a2f9c6d - Fix all remaining TypeScript build errors - add type annotations and missing service methods
Build started: 2025-10-26 21:59:00 UTC

📊 Overall Progress

Branch: copilot/fix-pr-1411-build-error-again
Status: 🔵 Building in progress
Preview URL (after completion): https://litlfred.github.io/sgex/copilot-fix-pr-1411-build-error-again/

💡 Build started for commit a2f9c6d. Will update when complete.

github-actions · 2025-10-26T14:46:17Z

🚀 Deployment Status: Building Application

📊 Deployment Information

Workflow: Deploy Feature Branch (🔀 Pull Request)
Action ID: 18819385247
Commit: 6a13f0a (view changes)
Workflow Step: Building Application

🔗 Quick Actions

(will be live after deployment)

📊 Overall Progress

Branch: copilot/fix-pr-1411-build-error-again
Status: 🟠 Compiling and bundling application code
Next: Deploying to GitHub Pages

📋 Deployment Timeline

2025-10-26 14:46:17 UTC - 🟢 Build Started - Initializing
2025-10-26 14:46:39 UTC - 🟢 Environment Setup Complete - In progress
2025-10-26 14:46:39 UTC - 🟠 Building Application - In progress

💡 This comment is automatically updated as the deployment progresses.

github-actions · 2025-10-26T14:46:42Z

🔒 Security Check Report

🟢 5 passed • 🟡 2 warnings

Security Checks

Check	Status	Details
NPM Audit	🟢	No vulnerabilities found
Outdated Dependencies	🟡	10 outdated packages (1 major versions behind)
ESLint Security	🟢	No security-related linting issues
Security Headers	🟡	Some security headers missing in source
License Compliance	🟢	No problematic licenses detected
Secret Scanning	🟢	No potential secrets detected in code
Framework Compliance	🟢	Framework compliance checks passed

🔍 Action Items

⚠️

Outdated Dependencies - 10 outdated packages (1 major versions behind)

Details:
Major version updates needed for:

react-syntax-highlighter

Recommendation: Review outdated packages and update where possible

⚠️

Security Headers - Some security headers missing in source

Details:

Recommendation: Ensure all security headers are properly defined

⚠️ Security Status: WARNINGS

Some security warnings were detected. Please review the action items above.

Last checked: Sun, 26 Oct 2025 21:59:05 GMT

This security check is automatically run on every PR build. Learn more about our security checks

litlfred · 2025-10-26T15:24:41Z

@copilot build error
TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
880 | setTimeout(async () => {
881 | try {

882 | const refreshedPRs = await fetchPRsForBranch(branchInfo?.name);
| ^^^^^^^^^^^^^^^^
883 | if (refreshedPRs && refreshedPRs.length > 0) {
884 | setPrInfo(refreshedPRs);
885 | }

…missing service methods Co-authored-by: litlfred <662242+litlfred@users.noreply.github.com>

Copilot · 2025-10-26T16:15:13Z

@copilot build error
TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
...

Fixed in commit a2f9c6d. Added null checks for branchInfo?.name in 3 locations and fixed all remaining TypeScript type errors including missing service methods.

github-actions · 2025-10-26T21:58:46Z