Expose DisconnectReason on Room#320
Open
MaxHeimbrock wants to merge 2 commits into
Open
Conversation
The Disconnected and ParticipantDisconnected FFI events already carry a DisconnectReason, but it was dropped before reaching the public API. - Add Room.DisconnectReason, set from the Disconnected event. - Add Room.DisconnectedWithReason (Room, DisconnectReason) alongside the existing parameterless Disconnected event. - Add Room.ParticipantDisconnectedWithReason (Participant, DisconnectReason) alongside the existing ParticipantDisconnected event. - Wire both into the Meet sample to log the reason. Existing event signatures are unchanged, so subscribers keep working. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
As from #53 Tested: Room: Participant: |
Drive Room.OnEventReceived with synthetic Disconnected and ParticipantDisconnected FFI events to verify the reason reaches Room.DisconnectReason, DisconnectedWithReason, and ParticipantDisconnectedWithReason. Also covers the default (UnknownReason) value. No server required. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
DisconnectedandParticipantDisconnectedFFI events already carry aDisconnectReason, but it was dropped before reaching the public C# API — there was no way to read why a room or participant disconnected.This surfaces it without breaking existing subscribers:
Room.DisconnectReasonproperty, set immediately before theDisconnectedevent fires.Room.DisconnectedWithReasonevent(Room, DisconnectReason)alongside the existing parameterlessDisconnected.Room.ParticipantDisconnectedWithReasonevent(Participant, DisconnectReason)alongside the existingParticipantDisconnected.Existing
Disconnected/ParticipantDisconnectedsignatures are unchanged, so current code keeps compiling.Usage
Testing
Project opens and compiles cleanly in Unity.
🤖 Generated with Claude Code