Skip to content

Update jupyter-html deps (major) #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
+562 −643
Open

Update jupyter-html deps (major) #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions livekit-rtc/jupyter-html/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@
"react-dom": "^19.2.4"
},
"devDependencies": {
"@eslint/js": "^9.39.3",
"@eslint/js": "^10.0.0",
"@types/react": "^19.2.14",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^4.7.0",
"eslint": "^9.39.3",
"eslint-plugin-react-hooks": "^5.2.0",
"@vitejs/plugin-react": "^6.0.0",
"eslint": "^10.0.0",
"eslint-plugin-react-hooks": "^7.0.0",

@devin-ai-integration devin-ai-integration Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 eslint-plugin-react-hooks v7 API compatibility with eslint config

The eslint config at livekit-rtc/jupyter-html/eslint.config.js:21 accesses reactHooks.configs.recommended.rules to spread rules. With eslint-plugin-react-hooks jumping from v5 to v7, the shape of the exported config object may have changed. The lockfile resolves v7.1.1 successfully, but whether the .configs.recommended.rules path still exists at runtime depends on the plugin's v7 API. This should be verified by running the lint script.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"eslint-plugin-react-refresh": "^0.5.0",
"globals": "^17.0.0",
"typescript": "~5.9.0",
"typescript": "~6.0.0",
"typescript-eslint": "^8.56.1",
"vite": "^6.4.1",
"vite": "^8.0.0",
Comment on lines +23 to +30

@devin-ai-integration devin-ai-integration Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Multiple major version skips in dependency bumps

Several dependencies skip major versions: @vitejs/plugin-react jumps from ^4 to ^6 (skipping v5), eslint-plugin-react-hooks from ^5 to ^7 (skipping v6), and vite from ^6 to ^8 (skipping v7). The lockfile confirms these all resolve successfully (6.0.2, 7.1.1, 8.0.13 respectively), suggesting these version numbers are correct for the packages' release histories. However, it may be worth confirming that CI builds and linting pass with these major version bumps, as the eslint flat config at eslint.config.js:21 accesses reactHooks.configs.recommended.rules which could have changed shape in react-hooks v7.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"vite-plugin-singlefile": "^2.3.0"
}
}
Loading
Loading