-
Notifications
You must be signed in to change notification settings - Fork 218
Add csv output for latency benchmarks to local_video example #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chenosaurus
wants to merge
10
commits into
main
Choose a base branch
from
dc/latency_metrics_csv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,888
−230
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
eb5297f
Add latency metrics CSV logging
chenosaurus 5bf977d
remove changeset for example
chenosaurus 57d60e2
Move latency CSV tests to module bottoms
chenosaurus 7e3eded
Move publisher diagnostics into a separate window
chenosaurus 437f589
Merge origin/main into dc/latency_metrics_csv
chenosaurus 9b5c477
updating report layout
chenosaurus f5655ea
update report rendering
chenosaurus 6ac8ab8
auto-stop process after logging
chenosaurus ca5fe1d
fix timing to separate receive / assembly from decode
chenosaurus 53b421b
fix color
chenosaurus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Pull request is missing the required change-documentation entry
The change adds new cross-crate functionality (new subscribe-timing and decode-timestamp entry points at
webrtc-sys/src/video_frame.rs:46-49) without adding the change note the repository requires for every pull request, so the release notes and version bumps will omit it.Impact: Released crates will not document or bump versions for this behavioral change.
Repository rule and current state
AGENTS.mdstates under "Documenting changes": "Every PR needs a changeset" and "Changeset must list any crates which need to be bumped stemming from the change".git diff --name-only <merge-base> HEAD -- .changeset/returns nothing for this PR; the only file in/.changesetcomes from an earlier commit (0aea78ff). This PR toucheslibwebrtc,webrtc-sys(new FFI surfacedecode_start_timestamp_us,decode_finish_timestamp_us,emit_subscribe_timing_at) and changes receive/decode timing semantics, so those crates need to be listed.Was this helpful? React with 👍 or 👎 to provide feedback.