Skip to content

TEL-892: Overriding the To user when req.ToUserOverride is present - #795

Merged
genseric-ghiro merged 3 commits into
mainfrom
genseric/ovewriting_user_when_ToUserOverride_is_present
Aug 17, 2026
Merged

TEL-892: Overriding the To user when req.ToUserOverride is present#795
genseric-ghiro merged 3 commits into
mainfrom
genseric/ovewriting_user_when_ToUserOverride_is_present

Conversation

@genseric-ghiro

@genseric-ghiro genseric-ghiro commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

@genseric-ghiro genseric-ghiro self-assigned this Aug 14, 2026
@genseric-ghiro
genseric-ghiro requested a review from a team as a code owner August 14, 2026 21:53
devin-ai-integration[bot]

This comment was marked as resolved.

@nishadmusthafa nishadmusthafa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if there's no way to bypass the protocol validation, I think we should be good.

devin-ai-integration[bot]

This comment was marked as resolved.

@genseric-ghiro

Copy link
Copy Markdown
Contributor Author

Yeah, if there's no way to bypass the protocol validation, I think we should be good.

The format validation for userToOverride is already done in NewCreateSIPParticipantRequestResult at the protocol level. However, CreateSIPParticipantRequest is an exported field, so it could be set directly without using the constructor (which isn't the case anywhere today). To prevent that edge case, adding some validation at the sip level as well.

@genseric-ghiro
genseric-ghiro merged commit ce06795 into main Aug 17, 2026
6 of 7 checks passed
@genseric-ghiro
genseric-ghiro deleted the genseric/ovewriting_user_when_ToUserOverride_is_present branch August 17, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants