ci: catch drift in the restated orchestrator commands - #71
Closed
rickstaa wants to merge 1 commit into
Closed
Conversation
echo dropped audio in three places, so trickle looked video-only: the client decoded video=0, the runner returned None for non-video frames, and only a video track was published. A stream with sound came back silent with no explanation. robot ring-modulates the audio and leaves the video alone, which makes the round trip audible. Ring modulation rather than a pitch shift because it preserves the sample count, so audio stays in sync without resampling. The output track is pinned to 48 kHz since opus rejects 44.1, which every consumer source produces. Only robot publishes an audio track: the container opens once every declared track has a first frame, so declaring audio for a silent input would stall the video. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51, taking the CI-guard option.
api-proxyandvllmrestate all sixteen orchestrator flags because static runners need-liveRunnerConfigandextendsreplaces a command list rather than appending to it. This checks those copies still match the shared file, and allows only that one flag to differ.It catches the case from the issue
Reproducing the #50 regression, where both copies kept
-ticketEV=1e9after the shared file moved to1e10:Also catches a flag deleted from a copy, and a flag added to a copy that is not in the allow-list.
Both sides, not just on-chain
The issue is about
compose.onchain.yml, but the same duplication exists offchain:api-proxy/compose.ymlandvllm/compose.ymlrestatecompose.orchestrator.yml's command too. The check covers both, four restated copies in total today.How it runs
A
localpre-commit hook, so the existing lint job picks it up with no workflow change.pass_filenames: falsebecause it always needs the shared file, with afiles:pattern so it only fires when a compose file is touched.It reads the tracked file list via
git ls-files, so a work-in-progress example directory that is not committed yet will not fail anyone's local run.Note on widening
When a genuinely new flag is needed by the static runners, add it to
ALLOWED_EXTRAin the script. That makes the exception explicit and reviewable rather than silent.