Hoist helper functions from Selection into Cursor class.#196
Merged
peyerluk merged 1 commit intolivingdocsIO:masterfrom Jul 1, 2021
Merged
Hoist helper functions from Selection into Cursor class.#196peyerluk merged 1 commit intolivingdocsIO:masterfrom
peyerluk merged 1 commit intolivingdocsIO:masterfrom
Conversation
90432f2 to
70840c6
Compare
peyerluk
reviewed
Nov 4, 2020
70840c6 to
df909ba
Compare
Contributor
Author
|
@peyerluk, I rebased on yesterday’s master. |
df909ba to
eda7c09
Compare
Contributor
Author
|
I removed the |
Collaborator
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
@peyerluk, @marcbachmann, when hoisting these three methods from Selection to Cursor I forgot to adjust the comments, e.g. “Get all tags that affect the current selection.” I think that should be “Get all tags that affect the current cursor or selection.”. Do you care, then I’ll add another PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helper function is useful to check whether the cursor is currently inside of a certain element. For example, within links I want to ignore split and linefeed events:
@peyerluk, I think you had implemented a similar function in PR #99 regarding links and not wanting to wrap a link in a link. This PR might support yours?