Skip to content

Bump netbird to v0.70.5#49

Open
lixmal wants to merge 1 commit into
mainfrom
auto/netbird-v0.70.5
Open

Bump netbird to v0.70.5#49
lixmal wants to merge 1 commit into
mainfrom
auto/netbird-v0.70.5

Conversation

@lixmal
Copy link
Copy Markdown
Owner

@lixmal lixmal commented May 6, 2026

Automated NetBird dependency update to v0.70.5.

Summary by CodeRabbit

  • Chores
    • Updated project dependencies to newer versions, including network routing and cryptography packages.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Walkthrough

The pull request updates Go module dependencies in go.mod. The netbird package is upgraded from v0.70.4 to v0.70.5, and the go-netroute library is upgraded from v0.2.1 to v0.4.0. Additionally, several indirect golang.org/x module dependencies are updated to newer minor versions, including updates to crypto, mod, net, sys, term, text, and tools packages. The changes encompass 9 lines in the manifest file.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change - upgrading netbird from v0.70.4 to v0.70.5, which is the main dependency update in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch auto/netbird-v0.70.5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 120: The go.mod update for module github.com/libp2p/go-netroute to v0.4.0
is being shadowed by the existing replace directive that points to the netbirdio
fork (the replace for github.com/libp2p/go-netroute ->
github.com/netbirdio/go-netroute at the commit referenced), so either remove or
adjust that replace: locate the replace directive for
github.com/libp2p/go-netroute (the replace on the netbirdio fork) and either
delete it if upstream v0.4.0 is acceptable, or update the replace target to a
newer fork commit/tag that incorporates the desired changes; after changing the
replace, run module verification (go mod tidy / build) to ensure the selected
version is actually used and tests/compilation pass.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 65f2da87-179b-4921-b2ae-0acc2f01ebfe

📥 Commits

Reviewing files that changed from the base of the PR and between fe5fc64 and 7d78fc7.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Comment thread go.mod
github.com/libdns/route53 v1.6.0 // indirect
github.com/libp2p/go-nat v0.2.0 // indirect
github.com/libp2p/go-netroute v0.2.1 // indirect
github.com/libp2p/go-netroute v0.4.0 // indirect
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

The go-netroute version update has no effect due to the replace directive.

Line 120 updates go-netroute to v0.4.0, but line 267's replace directive overrides this with the netbirdio fork from June 2024. The actual code being used remains unchanged by this update.

Consider either:

  • Updating the replace directive to a newer commit if the fork is still needed
  • Removing the replace directive if v0.4.0 is compatible with your requirements

Also applies to: 267-267

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 120, The go.mod update for module
github.com/libp2p/go-netroute to v0.4.0 is being shadowed by the existing
replace directive that points to the netbirdio fork (the replace for
github.com/libp2p/go-netroute -> github.com/netbirdio/go-netroute at the commit
referenced), so either remove or adjust that replace: locate the replace
directive for github.com/libp2p/go-netroute (the replace on the netbirdio fork)
and either delete it if upstream v0.4.0 is acceptable, or update the replace
target to a newer fork commit/tag that incorporates the desired changes; after
changing the replace, run module verification (go mod tidy / build) to ensure
the selected version is actually used and tests/compilation pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant