Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 New Features
Upsampling with Customizable Strategies
When drawing a waveform that is wider than the number of available audio samples, the scrubber now uses hardware-accelerated
vDSPinterpolation to intelligently "stretch" the data. This completely eliminates the visual gaps that occurred previously with drawers likeBarDrawer.You can now control the visual style of this upsampling by choosing a strategy in your
Drawer's configuration:.smooth(Default): Uses asimd_smoothstepfunction for a C² continuous, highly smoothed curve. The most visually pleasing option for most use cases..cosine: Uses a cosine curve for a smooth "ease-in, ease-out" effect..linear: Creates straight lines between sample points..hold: Repeats the previous sample's value, creating a "stepped" or blocky retro effect..none: Disables upsampling entirely, preserving the original behavior for custom use cases.New
invertedmode forLineDrawerThe
LineDrawernow includes aninvertedoption in its configuration, allowing you to create "cutout" or "trough" style waveforms.🛠️ Improvements & Refactoring
AudioProcessorinto dedicatedDownsamplerandUpsamplerservices. This adheres to the Single Responsibility Principle, making the codebase cleaner, more focused, and easier to maintain.UpsamplerandDownsamplerservices. This verifies the correctness of all interpolation and downsampling algorithms across various edge cases, ensuring high stability.staticto allow for direct and isolated unit testing.🐛 Bug Fixes
LineDrawerRendering Corrected: Fixed a critical bug whereLineDrawerwould draw an incorrect, asymmetrical shape. It now perfectly renders a symmetrical, closed path that matches the envelope of theBarDrawer.