Second step in re-organizing the code base#121
Open
shmuelk wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
the
size/M
ronenkat
reviewed
May 20, 2026
| package datastore | ||
|
|
||
| import "github.com/llm-d/llm-d-inference-payload-processor/pkg/framework/datalayer" | ||
| import "github.com/llm-d/llm-d-inference-payload-processor/pkg/framework/interface/datalayer" |
Contributor
There was a problem hiding this comment.
@shmuelk can we move the datastore.go into the datalayer?
it would make sense to have it co-hosted with the rest of the data layer artifacts.
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The remaining plugins and plugin related interfaces have been moved under ppkg/framework/plugins and pkg/framework/interfaces, respectively.
Why is this change needed?
Second step in re-organizing the code base to make it easier to find things and to avoid import loops.
How was this tested?
Checklist
git commit -s) per DCOmake test)make lint)