Skip to content

Enable warnings as errors#182

Open
slabasan wants to merge 4 commits intomainfrom
build/warnings-as-errors
Open

Enable warnings as errors#182
slabasan wants to merge 4 commits intomainfrom
build/warnings-as-errors

Conversation

@slabasan
Copy link
Copy Markdown
Collaborator

@slabasan slabasan commented Oct 22, 2024

Fixes #177

@slabasan slabasan requested a review from rountree as a code owner October 22, 2024 23:51
@rountree
Copy link
Copy Markdown
Collaborator

Ha! Foiled by msr-save. On my list.

@slabasan slabasan force-pushed the build/warnings-as-errors branch from e6c498a to 7ce8537 Compare October 25, 2024 04:46
@slabasan slabasan force-pushed the build/warnings-as-errors branch from 141ce25 to b5a448d Compare October 25, 2024 17:55
@slabasan
Copy link
Copy Markdown
Collaborator Author

@rountree I had a chance to fix the warnings this morning, does this look good to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error on warning during builds by default

2 participants