workflows/release-binaries: Checkout validate-release-version in upload step#209246
Open
tstellar wants to merge 1 commit into
Open
workflows/release-binaries: Checkout validate-release-version in upload step#209246tstellar wants to merge 1 commit into
tstellar wants to merge 1 commit into
Conversation
…ad step The upload-release-artifact composite action uses validate-release-version, so we need to make sure to check it out. Also, run the upload step during PR testing so we can catch errors like this in the future.
|
@llvm/pr-subscribers-github-workflow Author: Tom Stellard (tstellar) ChangesThe upload-release-artifact composite action uses Also, run the upload step during PR testing so we can catch errors like this in the future. Full diff: https://github.com/llvm/llvm-project/pull/209246.diff 1 Files Affected:
diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index 6fdf5e8c14cb8..2afaf70b5afd3 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -371,8 +371,6 @@ jobs:
needs:
- prepare
- build-release-package
- if: >-
- github.event_name != 'pull_request'
runs-on: ubuntu-24.04
permissions:
contents: write # For release uploads
@@ -386,6 +384,7 @@ jobs:
persist-credentials: false
sparse-checkout: |
.github/workflows/upload-release-artifact
+ .github/workflows/validate-release-version
llvm/utils/release/github-upload-release.py
llvm/utils/git/requirements.txt
sparse-checkout-cone-mode: false
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upload-release-artifact composite action uses
validate-release-version, so we need to make sure to check it out.
Also, run the upload step during PR testing so we can catch errors like this in the future.