Skip to content

[lldb-dap] Simplify DAPSessionManager GetInstance #209264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
da-viper merged 3 commits into from
Jul 14, 2026
Merged

[lldb-dap] Simplify DAPSessionManager GetInstance #209264

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55a842e
[lldb-dap] Simplify DAPSessionManager GetInstance
da-viper Jul 13, 2026
b726987
allocate the session manager on the heap
da-viper Jul 13, 2026
2746124
update the message
da-viper Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions lldb/tools/lldb-dap/DAPSessionManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,9 @@ ManagedEventThread::~ManagedEventThread() {
}

DAPSessionManager &DAPSessionManager::GetInstance() {
static std::once_flag initialized;
static DAPSessionManager *instance =
nullptr; // NOTE: intentional leak to avoid issues with C++ destructor
// chain

std::call_once(initialized, []() { instance = new DAPSessionManager(); });

// NOTE: Intentional leak. Detached client threads may still notify
// m_sessions_condition at exit, so it has to outlive them.
static auto *instance = new DAPSessionManager();
return *instance;
}

Expand Down
Loading