initial claude setup by AlexanderFengler · Pull Request #77 · lnccbrown/LANfactory

AlexanderFengler · 2026-03-28T16:16:30Z

This pull request adds important project documentation and enforces standardized Python package management practices. The most significant changes are the addition of a comprehensive project context file and a rules file that mandates the use of the uv package manager.

Documentation and Project Standards:

Added a detailed CLAUDE.md file describing the project's purpose, structure, build system, supported commands, architecture patterns (including network types and training backends), ONNX export process, HuggingFace integration, configuration and MLflow usage, CLI entry points, CI workflows, and known issues. This serves as a central reference for contributors and maintainers.

Python Package Management Rules:

Introduced .claude/rules/uv.md to enforce the use of uv as the package manager for all Python operations. This includes rules such as always using uv run for commands, never using pip install, and treating uv.lock as the source of truth for dependencies.

Copilot

Pull request overview

Adds contributor-facing documentation and Claude rules intended to standardize development workflows around uv and provide a single “project context” reference for LANfactory.

Changes:

Added CLAUDE.md with project structure, common commands, architecture notes, CLI entry points, CI workflow summary, and known issues.
Added .claude/rules/uv.md to enforce uv usage for Python execution and dependency management.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
`CLAUDE.md`	New central project context doc (commands, architecture, CLI/CI overview).
`.claude/rules/uv.md`	New Claude rule file to mandate `uv`-based workflows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-28T16:19:21Z

CLAUDE.md

+## Build & Tooling
+
+- **Build system:** setuptools (pure Python, no compiled extensions)
+- **Package manager:** uv (with `uv.lock`)


uv.lock is currently ignored by git in this repo (.gitignore contains uv.lock), so stating “uv.lock is the source of truth” (and implying it’s present) is misleading. Either commit uv.lock and remove it from .gitignore, or update this doc to reflect that the repo doesn’t track a lockfile.

Suggested change

- **Package manager:** uv (with `uv.lock`)

- **Package manager:** uv (no `uv.lock` committed; dependencies resolved from `pyproject.toml`)

Copilot · 2026-03-28T16:19:21Z

CLAUDE.md

+## Common Commands
+
+```bash
+# Install all dependencies (dev + optional)


uv sync --all-groups installs dependency groups (e.g. dev) but does not install optional extras, so the comment “dev + optional” is inaccurate. Consider either changing the text to “dev” only, or updating the command to include extras (e.g., add --all-extras or explicit --extra ...).

Suggested change

# Install all dependencies (dev + optional)

# Install all dependency groups (e.g. dev)

Copilot · 2026-03-28T16:19:21Z

CLAUDE.md

+Optional experiment tracking via MLflow. CLI flags: `--run-name`, `--experiment-name`,
+`--tracking-uri`, `--artifact-location`. Supports resuming runs via `--run-id`.


The MLflow CLI flag names in this section don’t match the actual CLI options in lanfactory.cli.{torch_train,jax_train} (they use --mlflow-run-name, --mlflow-experiment-name, --mlflow-tracking-uri, --mlflow-artifact-location, --mlflow-run-id). Updating these flags here will prevent users from copying commands that fail.

Suggested change

Optional experiment tracking via MLflow. CLI flags: `--run-name`, `--experiment-name`,

`--tracking-uri`, `--artifact-location`. Supports resuming runs via `--run-id`.

Optional experiment tracking via MLflow. CLI flags: `--mlflow-run-name`, `--mlflow-experiment-name`,

`--mlflow-tracking-uri`, `--mlflow-artifact-location`. Supports resuming runs via `--mlflow-run-id`.

Copilot · 2026-03-28T16:19:22Z

.claude/rules/uv.md

+- The `uv.lock` file is the source of truth for resolved dependency versions.
+- When adding dependencies, add them to `pyproject.toml` and run `uv sync`.


This rule says uv.lock is the source of truth, but the repository currently ignores uv.lock in .gitignore (so it won’t be committed/reviewed). To make this enforceable, either stop ignoring and commit uv.lock, or adjust the rule to reflect the current workflow (no checked-in lockfile).

Suggested change

- The `uv.lock` file is the source of truth for resolved dependency versions.

- When adding dependencies, add them to `pyproject.toml` and run `uv sync`.

- `pyproject.toml` is the source of truth for dependencies; `uv.lock` is a local resolution artifact and is not committed.

- When adding dependencies, add them to `pyproject.toml` and run `uv sync` to update your local `uv.lock`.

Copilot · 2026-03-28T16:19:22Z

.claude/rules/uv.md

+---
+
+- Always use `uv run` to execute commands — never bare `python`, `pytest`, `ruff`, or other tools.
+- Never use `pip install` — use `uv sync` (with `--extra` or `--all-groups` flags) to manage dependencies.


“Never use pip install” is too broad given the repo’s README still documents pip install lanfactory for end users. Consider scoping this rule explicitly to repository development/CI (e.g., “When working in this repo, don’t use pip; use uv…”) so it doesn’t conflict with published installation guidance.

Suggested change

- Never use `pip install` — use `uv sync` (with `--extra` or `--all-groups` flags) to manage dependencies.

- When working in this repo (local development, CI, or scripts), do not use `pip install`; instead use `uv sync` (with `--extra` or `--all-groups` flags) to manage dependencies. End‑user installation instructions in README or external docs may still use `pip install` where appropriate.

codecov · 2026-03-28T16:30:05Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
src/lanfactory/hf/upload.py	`100.00% <100.00%> (ø)`
src/lanfactory/trainers/torch_mlp.py	`94.17% <100.00%> (+0.01%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Remove uv.lock from .gitignore and commit lockfile - Raise check-added-large-files limit to 1000 KB - Fix uv sync comment: dev + optional -> all dependency groups - Fix MLflow CLI flags to use correct --mlflow- prefix - Scope no pip install rule to development only Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Match GitHub's own 100 MB hard limit rather than imposing an artificial lower threshold. Notebooks and lock files should not be blocked. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-30T22:55:55Z

src/lanfactory/trainers/torch_mlp.py

    if isinstance(network_config, str):
        with open(network_config, "rb") as f:
-            network_config = pickle.load(f)
+            network_config = pickle.load(f)  # noqa: S301



pickle.load() is being explicitly exempted from Ruff’s S301 security warning. If network_config can come from an untrusted path (e.g., user input/CLI), this is a code execution risk. Prefer a safe serialization format (YAML/JSON) for configs, or add an explicit trust boundary (validate/limit the config path and clearly document that only trusted pickles are supported) rather than blanket-suppressing the warning.

Copilot · 2026-03-30T22:55:55Z

src/lanfactory/trainers/torch_mlp.py

-            network_config = pickle.load(f)
+            network_config = pickle.load(f)  # noqa: S301

+    assert isinstance(network_config, dict)


Using assert isinstance(network_config, dict) for runtime input validation is brittle: assertions are stripped under python -O, and an AssertionError is not very actionable for users. Consider replacing this with an explicit TypeError/ValueError with a clear message (and, if relevant, include the path that was loaded) so failures are consistent in all runtime modes.

Copilot · 2026-03-30T22:55:56Z

CLAUDE.md

+- **Build system:** setuptools (pure Python, no compiled extensions)
+- **Package manager:** uv (with `uv.lock`)
+- **Python:** >3.10, <3.14 (classifiers target 3.11, 3.12, 3.13)
+- **Linting:** ruff (line length 120, via pre-commit)


The documented Ruff line length here (120) is inconsistent with the repo configuration (pyproject.toml sets [tool.ruff].line-length = 88). Please update this doc to match the actual configured value so contributors don’t format code to the wrong width.

Suggested change

- **Linting:** ruff (line length 120, via pre-commit)

- **Linting:** ruff (line length 88, via pre-commit)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

initial claude setup

b86c1f2

Copilot AI review requested due to automatic review settings March 28, 2026 16:16

Copilot started reviewing on behalf of AlexanderFengler March 28, 2026 16:16 View session

Copilot AI reviewed Mar 28, 2026

View reviewed changes

AlexanderFengler and others added 3 commits March 29, 2026 16:06

align pre-commit hooks across projects

255e95b

Raise check-added-large-files limit to ~99.9 MB

b458384

Match GitHub's own 100 MB hard limit rather than imposing an artificial lower threshold. Notebooks and lock files should not be blocked. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings March 30, 2026 22:52

Copilot started reviewing on behalf of AlexanderFengler March 30, 2026 22:53 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Fix documented ruff line length: 120 -> 88 to match pyproject.toml

dd26101

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

AlexanderFengler merged commit 047fa8e into main Mar 31, 2026
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

initial claude setup#77

initial claude setup#77
AlexanderFengler merged 5 commits intomainfrom
initial-claude-setup

AlexanderFengler commented Mar 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

codecov bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	- Package manager: uv (with `uv.lock`)
	- Package manager: uv (no `uv.lock` committed; dependencies resolved from `pyproject.toml`)

	# Install all dependencies (dev + optional)
	# Install all dependency groups (e.g. dev)

		Optional experiment tracking via MLflow. CLI flags: `--run-name`, `--experiment-name`,
		`--tracking-uri`, `--artifact-location`. Supports resuming runs via `--run-id`.

		- The `uv.lock` file is the source of truth for resolved dependency versions.
		- When adding dependencies, add them to `pyproject.toml` and run `uv sync`.

	- Never use `pip install` — use `uv sync` (with `--extra` or `--all-groups` flags) to manage dependencies.
	- When working in this repo (local development, CI, or scripts), do not use `pip install`; instead use `uv sync` (with `--extra` or `--all-groups` flags) to manage dependencies. End‑user installation instructions in README or external docs may still use `pip install` where appropriate.

	- Linting: ruff (line length 120, via pre-commit)
	- Linting: ruff (line length 88, via pre-commit)

Conversation

AlexanderFengler commented Mar 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Mar 28, 2026 •

edited

Loading