Skip to content

fix: map InvalidFileTypeError in error-map and allow image/heic uploads #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
islandbitcoin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: map InvalidFileTypeError in error-map and allow image/heic uploads #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21bed2d
fix: map InvalidFileTypeError in error-map and allow image/heic uploads
forge0x Mar 19, 2026
02c8157
fix: also map StorageError in error-map
forge0x Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/graphql/error-map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,14 @@ export const mapError = (error: ApplicationError): CustomApolloError => {
message: "Offer not available. Try again.",
logger: baseLogger
})
case "StorageError":
message = error.message
return new UnexpectedClientError({ message, logger: baseLogger })

case "InvalidFileTypeError":
message = error.message
return new ValidationInternalError({ message, logger: baseLogger })

// ----------
// Unhandled below here
// ----------
Expand Down
2 changes: 1 addition & 1 deletion src/services/storage/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { ErrorLevel } from "@domain/shared"

import { InvalidFileTypeError, StorageError } from "./errors"

const ALLOWED_CONTENT_TYPES = ["image/jpeg", "image/png", "image/webp"] as const
const ALLOWED_CONTENT_TYPES = ["image/jpeg", "image/png", "image/webp", "image/heic"] as const
const UPLOAD_URL_EXPIRY_SECONDS = 15 * 60 // 15 minutes
const READ_URL_EXPIRY_SECONDS = 60 * 60 // 1 hour

Expand Down