Open
Conversation
…ed to, creating a separate deployment branch for each (naming convention for master is explicitly unchanged)
…v$version for master
… changes This can happen if the version is bumped (in which case the new `plugins/v$version` branch needs to be created), or when dependencies are updated (which might also have an effect on the build)
it's not really necessary to stay "backwards compatible" here, because older versions of LNReader never made assumptions about these paths to begin with. And it only causes issues with the local test hosting. So for now I've made it so that both paths are ACTUALLY available, but only the new one is used is possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to improve upon the existing on-push CD pipeline for the repo. Currently it only pushes the
masterbranch toplugins/v${VERSION}; there was apparently an attempt to make this work for "all branches" in forks, but it doesn't work for me at all (partly because of weird secret handling).So this version vastly simplifies the process:
${{ github.token }}can just be used to get access to the repodist/$branchname. But if the current branch ismaster, the result will also be published atplugins/v$versionlike before.