Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devcontainers allow you to spin up a docker image defined by the developers, with preset instructions, and use it as a dev environment. It's also what gets used by github codespaces. Defining one theoretically lowers the bar to entry for would-be contributors, and can allow you to write code from anywhere.
You can also finish your work on a local VScode instance, where you could do the relevant testing.
I was able to get past CORS, but I couldn't find an example of a plugin that worked even then. Mostly cloudflare errors. I assume the IP ranges are blocked by webservers.
The local dev container I have tested and works fine, but did need to add host: true because otherwise it listened on ipv6, not ipv4, which is not productive.
Notable changes:
/plugins. To be extra safe, I added the-iflag, which makes it interactive, telling you what it will delete first.host: truein vite config