Add an optional wallet query param to indicate to the LN_SERVICE which wallet was used to authenticate#175
Open
steliosrammos wants to merge 1 commit intolnurl:ludsfrom
Open
Add an optional wallet query param to indicate to the LN_SERVICE which wallet was used to authenticate#175steliosrammos wants to merge 1 commit intolnurl:ludsfrom
wallet query param to indicate to the LN_SERVICE which wallet was used to authenticate#175steliosrammos wants to merge 1 commit intolnurl:ludsfrom
Conversation
Add an optional `wallet` query param to indicate to the `LN_SERVICE` which wallet was used to authenticate.
fiatjaf
changed the title
wallet query param to indicate to the LN_SERVICE which wallet was used to authenticate
Collaborator
|
Is this a terrible thing that destroys privacy? |
Contributor
Author
|
All that is shared is the wallet name. What are the privacy concerns you are thinking of? Since it's an optional param, a wallet could also prompt a user before hitting the |
Collaborator
|
I don't know. I generally don't care about that kind of privacy, just raising the question. |
Contributor
|
This could help fingerprint users, however, could be beneficial if we get into a world where some wallets support feature A,B,C and other wallets support X,Y,Z. Seems like PTLCs, BOLT12, AMP, Taro, etc are all moving this way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional
walletquery param to indicate to theLN_SERVICEwhich wallet was used to authenticate.