Add SQLite parser for iOS Accounts (Accounts3.sqlite) file#4926
Add SQLite parser for iOS Accounts (Accounts3.sqlite) file#4926studiawan wants to merge 14 commits intolog2timeline:mainfrom
Conversation
|
Hi @joachimmetz, I am not sure why test_docs / build (3.12, docs) failed. Can you show me where the error is? Other eight tests are successful. |
|
@studiawan I'm a bit preoccupied at the moment will try to take a look as soon as time permits |
| self.username = None | ||
| self.identifier = None | ||
| self.owning_bundle_id = None | ||
|
|
There was a problem hiding this comment.
style guide nit: have 2 empty lines
| """Retrieves a date and time value from the row. | ||
|
|
||
| Args: | ||
| query_hash (int): hash of the query, that uniquely |
There was a problem hiding this comment.
style guide nit: have 2 indentation spaces
| """iOS accounts event data. | ||
|
|
||
| Attributes: | ||
| date (dfdatetime.DateTimeValues): date and time the account |
There was a problem hiding this comment.
for consistency across the codebase changing this to creation_time
| account_type (str): account type. | ||
| username (str): user name. | ||
| identifier (str): identifier. | ||
| owning_bundle_id (str): owning bundle identifier of the app |
There was a problem hiding this comment.
style guide nit: id => identifier
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4926 +/- ##
==========================================
+ Coverage 85.09% 85.10% +0.01%
==========================================
Files 432 433 +1
Lines 38792 38827 +35
==========================================
+ Hits 33009 33043 +34
- Misses 5783 5784 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@studiawan what is the origin of the test data file? |
joachimmetz
added
the
pending reporter input
…al newline missing
|
|
||
| Attributes: | ||
| account_type (str): account type. | ||
| creation_time (dfdatetime.DateTimeValues): date and time the account |
There was a problem hiding this comment.
style guide nit: use 2 space indentation.
|
|
||
| REQUIRED_STRUCTURE = { | ||
| 'ZACCOUNT': frozenset([ | ||
| 'ZACCOUNTTYPE', 'ZDATE', 'ZUSERNAME', 'ZIDENTIFIER', |
There was a problem hiding this comment.
lint nit: remove trailing whitespace
I am sorry for the late reply, the data is from Digital Corpora https://digitalcorpora.s3.amazonaws.com/s3_browser.html#corpora/mobile/android_13/ios_15_3_1/ So, is the plugin good to be merged? |
Will need to check the license is compatible |
|
For the license, there are no restrictions on the use of this data, source: https://registry.opendata.aws/digitalcorpora/ |
|
That is the crux, need to figure out what "no restrictions" mean in the context of FOSS. Also see https://opensource.org/blog/public-domain-is-not-open-source |
joachimmetz
removed
the
pending reporter input
2 participants
One line description of pull request
Add SQLite parser for iOS Accounts (Accounts3.sqlite) file
Description:
I add/edit several files:
Related issue (if applicable): fixes #4135
Notes:
All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.
Checklist: