remove dependency on old standalone "mock"#5036
Closed
a-detiste wants to merge 2 commits intolog2timeline:mainfrom
Closed
remove dependency on old standalone "mock"#5036a-detiste wants to merge 2 commits intolog2timeline:mainfrom
a-detiste wants to merge 2 commits intolog2timeline:mainfrom
Conversation
this codebase already uses the newer "unittest.mock" from the standard library everywhere else
Member
|
Thanks for the proposed changes, given plaso uses l2tdevtools to generate dependency files, I've made comparable changes using l2tdevtools in #5038 Closing this PR in favor of 5038 |
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this codebase already uses the newer "unittest.mock" from the standard library everywhere else
--> it's actually the reverse here