handle fields that do not have a value splitter#103
Open
yaauie wants to merge 1 commit intologstash-plugins:mainfrom
Open
handle fields that do not have a value splitter#103yaauie wants to merge 1 commit intologstash-plugins:mainfrom
yaauie wants to merge 1 commit intologstash-plugins:mainfrom
Conversation
By prepending an optional, non-capturing field splitter to our scanning regexp
we ensure that a valueless key is fully consumed, preventing a multibyte field
splitter from partially leaking into the next key.
Correctly parses out `k1` => `v1` and `k2` => `v2` from any of the following
sequences using the field splitter `__`:
missing__k1=v1__k2=v2
k1=v1__missing__k2=v2
k1=v1__k2=v2__missing
Co-authored-by: Tom Gregory <thomas.gregory@elastic.co>
Contributor
|
Do we need to version up (and include changelog)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By prepending an optional, non-capturing field splitter to our scanning regexp
we ensure that a valueless key is fully consumed, preventing a multibyte field
splitter from partially leaking into the next key.
Correctly parses out
k1=>v1andk2=>v2from any of the followingsequences using the field splitter
__:Co-authored-by: Tom Gregory thomas.gregory@elastic.co