Fix integer conversion precision loss on JRuby 10 - #178
Merged
Conversation
`parse_signed_hex_str` applied `Float()` to all strings when JRuby 10's `Float()` gained signed hex support. This truncated values beyond 2^53. Restrict the `Float()` to hex strings only. Also use BigDecimal for float-string-to-integer conversion and declare bigdecimal as a runtime gem dependency for JRuby 10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_signed_hex_strappliedFloat()to all strings when JRuby 10'sFloat()gained signed hex support. This truncated values beyond 2^53. Restrict theFloat()to hex strings only.Also use BigDecimal for float-string-to-integer conversion and declare bigdecimal as a runtime gem dependency for JRuby 10.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/
Closes: #177