fix: Specifically cast passed in retries and timeout values to ints#104
Open
jrgns wants to merge 1 commit intologstash-plugins:mainfrom
Open
fix: Specifically cast passed in retries and timeout values to ints#104jrgns wants to merge 1 commit intologstash-plugins:mainfrom
jrgns wants to merge 1 commit intologstash-plugins:mainfrom
Conversation
Author
|
Will provide tests as soon as I have a gap :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
What does this PR do?
Specifically cast the
retriesandintervalsettings in thehostarray to integers. Since there's no validation on these values, if you set these values through ENV variables, they'll come through as strings.Why is it important/What is the impact to the user?
Users will like to set these values through ENV variables.
Checklist
How to test this PR locally
Related issues
None created
Logs