Merged
Conversation
Contributor
Author
|
I've identified a race condition in these tests that have to do with taking of ports. |
mightyiam
force-pushed
the
browser-tests
branch
3 times, most recently
from
5700496 to
2b8583f
Compare
Contributor
Author
|
I've added a test that seems to prove that |
shivaraj-bh
force-pushed
the
browser-tests
branch
4 times, most recently
from
6067d92 to
f308063
Compare
mightyiam
force-pushed
the
browser-tests
branch
2 times, most recently
from
7e6a6fe to
d6a8ab1
Compare
mightyiam
force-pushed
the
browser-tests
branch
2 times, most recently
from
4306677 to
133eb1d
Compare
mightyiam
force-pushed
the
browser-tests
branch
2 times, most recently
from
b268f59 to
e9ba792
Compare
Contributor
Author
|
It seems like I've ironed out the last race condition with the help of @phanirithvij. And the symlink swapping test ended up flaky (which I'm somewhat happy about, because I am claiming that feature doesn't work) so I've removed it and included it in #192. |
Owner
|
Thanks, LGTM. Just need to fix the merge conflicts. |
Co-authored-by: turbio <git@turb.io> Co-authored-by: shivaraj-bh <me@shivaraj-bh.in>
mightyiam
force-pushed
the
browser-tests
branch
from
e9ba792 to
6bc94e0
Compare
Contributor
Author
|
There you go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a good idea anyway. But my motivation for this is following up with adding a test for #161.