Chore: remove duplicates and fix maintenance issues#21
Merged
Conversation
- dotfiles/.zshrc: remove duplicate tmux auto-attach block (lines 166-169); superseded by .zshrc.d/tmux.zsh which uses exec and also skips VSCode terminal - uninstall.sh: add tmux.zsh to ZSHRC_D_FILES so it is cleaned up on uninstall - tests/test_configs.sh: add tmux.zsh to .zshrc.d file existence check - README.md/ja/zh: fix tmux description — remove incorrect "named main" session reference to match actual tmux.zsh behavior - CLAUDE.md: add tmux.zsh to .zshrc.d structure listing; annotate core.sh with tmux.zsh deployment - CHANGELOG.md: add [0.5.0] entry covering kali-style prompt, tmux auto-attach, CI/ShellCheck fixes, and this maintenance cleanup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The previous commit inadvertently changed uninstall.sh from 100755 to 100644 (non-executable) due to Windows/WSL filesystem mode handling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotfiles/.zshrc: remove duplicate tmux auto-attach block (lines 166-169) — superseded by.zshrc.d/tmux.zshwhich usesexec(exit tmux = exit shell) and also skips VSCode terminal; the two blocks had inconsistent behavior (tmux-devnamed session vs unnamed)uninstall.sh: addtmux.zshtoZSHRC_D_FILESso it is properly removed on uninstalltests/test_configs.sh: addtmux.zshto.zshrc.dfile existence check (was missing, test now covers all deployed files)README.md/README.ja.md/README.zh.md: fix tmux session description — remove incorrect "namedmain" reference;tmux.zshattaches to the most recent existing session or creates a new unnamed oneCLAUDE.md: addtmux.zshto.zshrc.d/structure listing; annotatecore.shwithtmux.zshdeploymentCHANGELOG.md: add[0.5.0]entry covering Kali-style prompt, tmux auto-attach, CI/ShellCheck fixes, and this maintenance cleanupTest plan
bash tests/run_tests.sh)install_and_configure.sh(CI-protected legacy script untouched)🤖 Generated with Claude Code