Change motor and psycopg2 to be required dependencies, not optional.#90
Open
showtimezz wants to merge 1 commit intolong2ice:devfrom
Open
Change motor and psycopg2 to be required dependencies, not optional.#90showtimezz wants to merge 1 commit intolong2ice:devfrom
showtimezz wants to merge 1 commit intolong2ice:devfrom
Conversation
|
This is also the behavior on my machine too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply running
pip install mailsyncand attempting to run it results in the following issues.Now, for example, only installing support for MongoDB with
pip install meilisync[mongodb]fixes the issue with themotorpackage, however, it's still not running until you installpsycopg2.I'm guessing this is a case of segmenting the package more, or the easier route of listing these as regular dependencies, not optional ones until a better solution is implemented, if that's something the original author wants to pursue.
I've double checked that this is the behavior when running this via poetry on my local machine.