docs: Refine claude skills with respect to safe reentrancy#2362
Merged
Conversation
huacnlee
changed the title
Member
|
Thanks |
AzureZee
pushed a commit
to AzureZee/gpui-component
that referenced
this pull request
May 16, 2026
…e#2362) <!-- Closes #[issue number] --> ## Description I'm finding that Claude keeps falling into the same trap when implementing custom components (such as longbridge#2319): > thread 'main' (…) panicked at …: > cannot update … while it is already being updated The proposed skill changes aim to address these weaknesses. ## Screenshot n/a ## Break Changes n/a ## How to Test n/a ## Checklist - [x] I have read the [CONTRIBUTING](../CONTRIBUTING.md) document and followed the guidelines. - [x] Reviewed the changes in this PR and confirmed AI generated code (If any) is accurate. - [x] Passed `cargo run` for story tests related to the changes. - [x] Tested macOS, Windows and Linux platforms performance (if the change is platform-specific)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm finding that Claude keeps falling into the same trap when implementing custom components (such as #2319):
The proposed skill changes aim to address these weaknesses.
Screenshot
n/a
Break Changes
n/a
How to Test
n/a
Checklist
cargo runfor story tests related to the changes.