Conversation
…x`, and `MultiComboBox`
…ableListAdapter` `item_renderer` hook
…lect - Rename module `combo_box` → `combobox` and all types (`ComboBox`→`Combobox`, `ComboBoxState`→`ComboboxState`, etc.) - Replace `ComboBoxMode::Single/Multi` enum with a `multiple(bool)` prop, matching Shadcn Combobox API (`multiple` attribute) - Remove `close_on_select`: behavior is now derived from `multiple` (single→close on select, multiple→stay open), matching Shadcn semantics Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…inks Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…or unified multiple(bool) - Add Select vs Combobox feature comparison table - Highlight multi-select as the key differentiator from Select - Fix import section: remove deprecated MultiComboBox/MultiComboBoxState types - Fix all code examples to use current API (ComboboxState, multiple(true), vec![] indices) - Fix ComboboxTriggerCtx usage: ctx.selection instead of ctx.selected_item - Merge single/multi-select sections into unified usage examples Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Rename trigger_icon() → icon() to match Select's convention - Add selected_value() → Option<Value> convenience for single-select - Add window param to set_selected_indices() to match set_selected_index() in Select - Restrict handle_item_select to pub(crate) — internal/test use only Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ger closures Callers no longer need .into_any_element() — the conversion happens inside the builder method. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
"El" abbreviation is not allowed by project convention. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…dule - Rename `ComboboxTriggerCtx` → `ComboboxTriggerContext` (no abbreviations) - Make `searchable_list` module `pub(crate)`; re-export needed types from `combobox` so users can import via `combobox::*` without touching the internal module - Remove dead `is_open` / `focus_handle` methods from `SearchableListState` (became unreachable after visibility change) - Update `combobox_story.rs` to drop direct `searchable_list` import - Sync docs (EN + zh-CN): fix import block and `ComboboxTriggerContext` refs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rror The bnjbvr/cargo-machete@v0.9.1 action uses clechasseur/rs-cargo@v3 internally which invokes `cargo +stable install`, causing a failure in the CI environment that doesn't support the toolchain override syntax. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
searchable_listmodule shared bySelect,ComboboxComboboxcomponent with single/multi-select support, inspired by Shadcn Combobox API:multiple(bool)prop instead of aComboBoxModeenum — aligns with Shadcn'smultipleattributeclose_on_selectneededrender_triggerclosure for fully custom trigger renderingfooterslot for bottom-of-popup actionscheck_iconoverride for selected-item indicatorsearchable(bool)for in-popup search filteringcombobox/Combobox(notcombo_box/ComboBox)ComboboxStorygallery with demo sections covering single, multi, grouped, custom trigger, footer, chip badges, and delegate hooksTest plan
cargo run) and verify Combobox panel renders correctly.multiple(true)): selecting items toggles them, popup stays open, trigger shows comma-separated titlesrender_triggerrenders correctly🤖 Generated with Claude Code