Skip to content

Fix WASM highlighter stub mismatch in release docs build#2452

Merged
huacnlee merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job
Jun 9, 2026
Merged

Fix WASM highlighter stub mismatch in release docs build#2452
huacnlee merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

The Release Docs workflow was failing in the Build Story Web (WASM) step because the WASM-only HighlightThemeStyle stub had drifted from the native struct shape. This patch restores parity by adding the missing gutter background field used by the input renderer.

  • Root cause

    • crates/ui/src/input/element.rs now reads highlight_theme.style.editor_gutter_background
    • crates/ui/src/highlighter/wasm_stub.rs did not define that field, so wasm32-unknown-unknown builds failed
  • Change

    • Add editor_gutter_background: Option<gpui::Hsla> to the WASM stub
    • Preserve the serialized theme key with #[serde(rename = "editor.gutter.background")]
#[serde(rename = "editor.gutter.background")]
pub editor_gutter_background: Option<gpui::Hsla>,

Screenshot

Before After
WASM build fails with no field editor_gutter_background on type wasm_stub::HighlightThemeStyle WASM highlighter stub matches native theme style and the build proceeds

Break Changes

None.

How to Test

  1. Run cargo build --target wasm32-unknown-unknown -p gpui-component
  2. Optionally run the release-docs build path from crates/story-web:
    • make build-prod

Checklist

  • I have read the CONTRIBUTING document and followed the guidelines.
  • Reviewed the changes in this PR and confirmed AI generated code (If any) is accurate.
  • Passed cargo run for story tests related to the changes.
  • Tested macOS, Windows and Linux platforms performance (if the change is platform-specific)

Copilot AI changed the title [WIP] Fix failing GitHub Actions job "build" Fix WASM highlighter stub mismatch in release docs build Jun 9, 2026
Copilot AI requested a review from huacnlee June 9, 2026 08:18
@huacnlee huacnlee marked this pull request as ready for review June 9, 2026 10:14
@huacnlee huacnlee merged commit 8752104 into main Jun 9, 2026
3 checks passed
@huacnlee huacnlee deleted the copilot/fix-failing-github-actions-job branch June 9, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants