input: use the native OS context menu on right-click#2453
Merged
Conversation
- macos: refresh the window after the AppKit tracking loop returns so a dismissed native menu does not leave the window idle and unresponsive to a second right-click (covers the dismiss-without-selection path) - input: remove the RightClick variant from the popover ContextMenu enum Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Migrate remaining PopupMenu-based callers to popup_context_menu, drop the removed Input custom context menu API and the orphaned InputContextMenu, and update stories accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… NativeMenu Revert the ContextMenuExt::context_menu -> NativeMenu change. The trait keeps its original PopupMenu semantics (so sidebar/table/tree/stories stay unchanged and keep closure callbacks, custom suffix/label/link), and the native menu is reached only through the standalone NativeMenu component (the input right-click menu already calls NativeMenu::show directly). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bring back Input::context_menu (custom builder) and InputState::context_menu (enable/disable), now backed by NativeMenu instead of PopupMenu. A custom builder fully replaces the built-in right-click menu; otherwise the default cut/copy/paste/select-all (plus code-editor actions) is shown. Restore the story demos accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
huacnlee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RightClickvariant from the popoverContextMenuenum as part of moving the input right-click menu over toNativeMenu.Completion/CodeActionare untouched.Test plan
🤖 Generated with Claude Code