text: fix stuck selection after clicking a link#2455
Open
linyisu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where dragging the mouse after clicking a link in a
TextViewcauses an unintended text selection.When a link is clicked, the
MouseUphandler callscx.stop_propagation()before opening the URL. This prevents the window-levelTextSelectionControllerfrom receiving the event, leavingis_selectingstuck attrue. Any subsequent mouse movement is then treated as a drag, highlighting text the user never intended to select.This PR calls
Root::end_text_selection(cx)beforestop_propagation()in both link paths:crates/ui/src/text/inline.rscrates/ui/src/text/node.rsScreenshot
Before
before.mp4
After
after.mp4
How to Test
Open any story that renders a
TextViewcontaining a link (e.g. the Markdown story).Click a link and let the browser open the URL.
Return to the app window and move the mouse without pressing any button.
Checklist
cargo runfor story tests related to the changes.