fix(#129): filter non-transaction rows from output#130
Closed
fix(#129): filter non-transaction rows from output#130
Conversation
Non-transaction rows (headers, totals, blanks) were passing the 'if row:'
guard in process_page() because they still held partial data. Changed to
'if row.get("Filename"):' — Filename is only stamped by RowPostProcessor
on rows that pass transaction classification, making it a reliable sentinel.
Removes empty rows from CC output (bank_statements_9459: 22 -> 15 rows).
Owner
Author
|
Closing — fix was too aggressive. The empty rows (4 Feb, 12 Feb, 18 Feb) are actually real transactions being misclassified as 'metadata' by the row classifier because the CC statement splits each transaction across two lines (transaction data + reference number). The row merger is not combining these continuation lines correctly for the CC template. Root cause is in row merging, not row filtering. Will be tracked separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #129
if row:toif row.get("Filename"):inStatefulPageRowProcessor.process_page()Filenameis only stamped byRowPostProcessoron rows that pass transaction classification — making it a reliable sentinel to exclude headers, totals, and blank rowsTest plan
bank_statements_9459row count 22 → 15 (7 empty rows removed)