Skip to content

refactor(#45): delete TransactionProcessingOrchestrator#46

Merged
longieirl merged 1 commit intomainfrom
fix/45-delete-transaction-processing-orchestrator
Mar 25, 2026
Merged

refactor(#45): delete TransactionProcessingOrchestrator#46
longieirl merged 1 commit intomainfrom
fix/45-delete-transaction-processing-orchestrator

Conversation

@longieirl
Copy link
Copy Markdown
Owner

Summary

Completes the cleanup from PR #44. `TransactionProcessingOrchestrator` was retained for backward compatibility after `ServiceRegistry` took over the pipeline — it is now fully redundant and removed.

Changes

  • Delete `services/transaction_processing_orchestrator.py`
  • Delete `tests/services/test_transaction_processing_orchestrator.py`
  • Remove unused import and instantiation of `TransactionProcessingOrchestrator` from `processor.py`
  • Clean up stale docstring references in `service_registry.py`

Type

  • Refactoring

Testing

  • Tests pass (coverage ≥ 91%)
  • Manually tested

Checklist

  • Code follows project style
  • Self-reviewed
  • Documentation updated (if needed)
  • No new warnings

Closes #45

- Remove transaction_processing_orchestrator.py and its test file
- Remove unused import and instantiation from processor.py
- Clean up stale docstring references in service_registry.py

group_by_iban is now accessed via ServiceRegistry directly.
@github-actions github-actions bot added the bug Something isn't working label Mar 25, 2026
@longieirl longieirl self-assigned this Mar 25, 2026
@longieirl longieirl merged commit afd79b9 into main Mar 25, 2026
11 checks passed
@longieirl longieirl deleted the fix/45-delete-transaction-processing-orchestrator branch March 25, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: delete TransactionProcessingOrchestrator now that ServiceRegistry owns the pipeline

2 participants