fix(#59): add make docker-integration target for local Docker validation#69
Closed
fix(#59): add make docker-integration target for local Docker validation#69
Conversation
Adds a local-only Docker integration test that builds the image and runs the container against input/, asserting non-zero transaction output. PR template updated to prompt contributors to run it when touching the pipeline or Docker config.
Owner
Author
|
Closing to rework — docker-integration target needs proper snapshot comparison logic aligned with pytest -m integration. See issue #59. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the local Docker testing gap identified in #59 — without touching CI.
Changes
docker-integrationtarget — builds the image, mountsinput/read-only, runs the container, asserts ≥1 transaction extracted, then cleans up. Fails fast with a clear message ifinput/has no PDFs.make docker-integrationwhen touchingDockerfile,entrypoint.sh,docker-compose.yml, orpackages/parser-core/.Type
Testing
make docker-integrationpassed locally (required when touchingDockerfile,entrypoint.sh,docker-compose.yml, orpackages/parser-core/)Checklist