fix(#59): local Docker integration test with snapshot comparison#70
Merged
fix(#59): local Docker integration test with snapshot comparison#70
Conversation
Adds a local-only Docker integration test that builds the image and runs the container against input/, asserting non-zero transaction output. PR template updated to prompt contributors to run it when touching the pipeline or Docker config.
… comparison - Gitignore output_snapshot.json — personal to each dev, never committed - test_output_snapshot.py docstring updated to reflect local-only intent - make docker-integration now calls docker_snapshot.py for full snapshot comparison (same logic as pytest -m integration); UPDATE=1 to baseline - docker_snapshot.py: standalone script mirroring _build_snapshot() logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns Docker integration testing with the existing Python integration test — same snapshot file, same logic, local-only.
Changes
output_snapshot.jsonis now gitignored — personal to each developer's input PDFs, never committed. The copy onmainis kept as a reference.test_output_snapshot.py: docstring updated to reflect local-only intent (remove 'committed to source control' language).docker_snapshot.py: new standalone script that builds the same snapshot structure as the Python test and either updates the baseline or diffs against it.Makefile:docker-integrationtarget rewired to calldocker_snapshot.py. First run:make docker-integration UPDATE=1to create baseline. Subsequent runs:make docker-integrationto validate.Usage
Type
Testing
make docker-integrationpassed locallyChecklist