Open
Conversation
Add SetControls method on LDAPMessage to allow setting controls on outgoing messages, and NewControl constructor to create Control values from Go native types.
These methods were only available on LDAPResult but not on SearchResultDone which is a distinct defined type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewControl(controlType, criticality, value)- constructor for buildingControlvaluesLDAPMessage.SetControls(controls)- attach controls to the message envelopeSearchResultDone.SetDiagnosticMessage(msg)- set diagnostic message on search resultsSearchResultDone.SetReferral(referral)- attach referral URLs to search resultsThese are needed to build LDAP servers that return controls and referrals in responses, as required by RFC 4511 sections 4.1.11 (Controls) and 4.1.10 (Referral).
Used in vjeantet/ldapserver to support
WriteWithControls(),NewReferral(), andNewSearchResultReference().Changes
Two small commits, no breaking changes, all new public API surface:
message/control.go- addNewControl()constructormessage/message.go- addSetControls()method onLDAPMessagemessage/search_result_done.go- addSetDiagnosticMessage()andSetReferral()methods