feat: add agent auto-review mode - #8
Merged
Merged
Conversation
Adds a fourth session mode `agent-auto-review`: same workspace-write sandbox and on-request approval policy as `agent`, but routes approval requests to Codex's auto-review subagent (`approvalsReviewer: auto_review`) instead of the ACP client, matching the Codex app's "Approve for me" permission preset. Model: kimi-code/k3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a fourth ACP session mode
agent-auto-review("Agent (auto review)"), exposing Codex's "Approve for me" permission preset (approvals_reviewer = "auto_review") through the adapter.src/AgentMode.ts: newAgentMode.AgentAutoReview— same workspace-write sandbox andon-requestapproval policy asagent, plus a newapprovalsReviewerfield defaulting to"user".src/CodexAcpClient.ts: passesapprovalsReviewerinturn/startparams, so approval requests (sandbox escapes, network access, MCP prompts) are routed to Codex's auto-review subagent instead of the ACP client.README.md/readme-dev.md: document the newINITIAL_AGENT_MODEid.With this mode active, Codex reviews and approves/denies permission requests automatically with its risk-based reviewer subagent; the client no longer receives a permission prompt for each request.
Test
npm run typecheckcleannpx vitest run --exclude '**/e2e/**': 320 passed (updated theturn/startsnapshot for the newapprovalsReviewerfield)Model: kimi-code/k3