Open
Conversation
sclaiborne
reviewed
Sep 3, 2024
Member
sclaiborne
left a comment
sclaiborne
left a comment
There was a problem hiding this comment.
- Can you clarify why arm is not supported?
- Is it okay to add rtk lib to public repo?
Member
Author
It throws compile errors when I try to build with these two function on ARM with GCC 11
It's included in AS.. so I assume it OK? Turns out it's always been in there. "C:\BrAutomation\AS\System\C0463\SG4\IA32.." has a bunch of .a libraries. This is just a way to get AS to link against it automagically |
Member
Author
|
I could see removing the headers from RTK |
Member
I am not sure what the right decision is there |
sclaiborne
approved these changes
Sep 3, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Start adding support for AS6
Notes:
This PR removes support for some time functions in ARM that don't appear to be supported. We might want to fix it.
This PR uses a new TLSF library that is yet unrelease.
This PR doesn't support auto building yet