Correct Integer Handling decToBin.cpp#566
Open
aadityaa-g18 wants to merge 1 commit intoloveBabbar:mainfrom
Open
Correct Integer Handling decToBin.cpp#566aadityaa-g18 wants to merge 1 commit intoloveBabbar:mainfrom
aadityaa-g18 wants to merge 1 commit intoloveBabbar:mainfrom
Conversation
Using pow(10, i), which can cause floating-point precision errors. Using pow(10, i) returns a floating-point value, which is then implicitly converted to an integer during the addition.This can result in precision issues. Instead, you should use integer multiplication for precise operations. To ensure correct integer handling, we will replace pow(10, i) with ans = (bit * place) + ans where place is multiplied by 10 in each loop iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using pow(10, i), which can cause floating-point precision errors.
Using pow(10, i) returns a floating-point value, which is then implicitly converted to an integer during the addition.This can result in precision issues. Instead, you should use integer multiplication for precise operations.
To ensure correct integer handling, we will replace pow(10, i) with ans = (bit * place) + ans where place is multiplied by 10 in each loop iteration.