[proj] UART D1 sign-off#574
Merged
Merged
Conversation
marnovandermaas
requested review from
KinzaQamar,
elliotb-lowrisc,
engdoreis,
martin-velay,
raylau1 and
rswarbrick
marnovandermaas
force-pushed
the
uart_d1
branch
2 times, most recently
from
3b8f98d to
636f73d
Compare
Closed
elliotb-lowrisc
approved these changes
May 21, 2026
Contributor
elliotb-lowrisc
left a comment
elliotb-lowrisc
left a comment
There was a problem hiding this comment.
Seems good to me
martin-velay
approved these changes
May 21, 2026
Contributor
martin-velay
left a comment
martin-velay
left a comment
There was a problem hiding this comment.
Just a little change suggested, but it looks good.
NOTE:
I'll reuse this format to create a template as initiated in this PR
engdoreis
approved these changes
May 21, 2026
martin-velay
approved these changes
May 21, 2026
Contributor
martin-velay
left a comment
martin-velay
left a comment
There was a problem hiding this comment.
Approve again after last changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D1 sign-off for UART. This pull request should have three approvers before merging.
Closes: #496