fix: remove extra trailing slash in filepath.expand#11
Merged
Conversation
lpil
reviewed
Mar 29, 2025
Owner
lpil
left a comment
There was a problem hiding this comment.
Hello! I'm not sure what this is because there's no issue, description, or tests.
Could you write tests and update the changelog please 🙏
Contributor
Author
|
Hi! PS> dir env:\OS
Name Value
---- -----
OS Windows_NT
PS> gcim win32_operatingsystem
SystemDirectory Organization BuildNumber RegisteredUser SerialNumber Version
--------------- ------------ ----------- -------------- ------------ -------
C:\Windows\system32 26100 Op 00436-20000-00000-AAOEM 10.0.26100
PS> G:\gleam_scratch\filepath git:[windows]
gleam test
Compiling filepath
Compiled in 3.21s
Running filepath_test.main
........F.
Failures:
1) filepath_test.expand_test
Values were not equal
expected: Ok("/one")
got: Ok("/one/")
output:
Finished in 0.201 seconds
10 tests, 1 failures The PR fixes this error (on Windows) |
Owner
|
Ah! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.