Conversation
Bumps the bundler group with 1 update in the / directory: [rack](https://github.com/rack/rack). Updates `rack` from 3.1.18 to 3.1.20 - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md) - [Commits](rack/rack@v3.1.18...v3.1.20) --- updated-dependencies: - dependency-name: rack dependency-version: 3.1.20 dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [minimatch](https://github.com/isaacs/minimatch). Updates `minimatch` from 3.1.2 to 3.1.4 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.1.2...v3.1.4) --- updated-dependencies: - dependency-name: minimatch dependency-version: 3.1.4 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
…9e58 Bump rack from 3.1.18 to 3.1.20 in the bundler group across 1 directory
…arn-c7796958eb Bump minimatch from 3.1.2 to 3.1.4 in the npm_and_yarn group across 1 directory
Bumps the bundler group with 1 update in the / directory: [nokogiri](https://github.com/sparklemotion/nokogiri). Updates `nokogiri` from 1.18.9 to 1.19.1 - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.18.9...v1.19.1) --- updated-dependencies: - dependency-name: nokogiri dependency-version: 1.19.1 dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <support@github.com>
…44a8 Bump nokogiri from 1.18.9 to 1.19.1 in the bundler group across 1 directory
Bumps the npm_and_yarn group with 1 update in the / directory: [immutable](https://github.com/immutable-js/immutable-js). Updates `immutable` from 4.3.5 to 4.3.8 - [Release notes](https://github.com/immutable-js/immutable-js/releases) - [Changelog](https://github.com/immutable-js/immutable-js/blob/main/CHANGELOG.md) - [Commits](immutable-js/immutable-js@v4.3.5...v4.3.8) --- updated-dependencies: - dependency-name: immutable dependency-version: 4.3.8 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
…istency. Updated manual payment link to use user_id directly from application object.
…ity. Removed commented-out code and streamlined user selection logic.
…ity and consistency.
…ers for payer identity and payment conference year, while updating existing filters for user email, first name, and last name to ensure distinct values. Updated ransackable attributes in Payment model to include payments_conf_year.
Fix manual payment link
…arn-e407d56523 Bump immutable from 4.3.5 to 4.3.8 in the npm_and_yarn group across 1 directory
…r user email, first name, and last name, ensuring distinct values are retrieved.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves ActiveAdmin filtering for Applications and Payments by replacing ambiguous/less-usable filters with more specific user- and application-attribute filters, and by adding a Ransack ransacker to disambiguate conf_year filtering on Payments when associations are joined.
Changes:
- Refactors ActiveAdmin filters for
ApplicationandPaymentto support filtering by user email and applicant name fields. - Adds a
payments_conf_yearRansack ransacker and allows it viaransackable_attributes, updating the corresponding model spec. - Updates dependency lockfiles (Ruby gems and Yarn packages).
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
app/admin/applications.rb |
Replaces user_id filter with user_email, first_name, last_name; fixes manual payment link param. |
app/admin/payments.rb |
Replaces user_id/conf_year filters with payer_identity, applicant name filters across associations, and payments_conf_year. |
app/models/payment.rb |
Adds payments_conf_year ransacker and whitelists it for Ransack. |
spec/models/payment_spec.rb |
Updates Ransack whitelist spec to include payments_conf_year. |
Gemfile.lock |
Bumps locked gem versions (e.g., nokogiri, rack). |
yarn.lock |
Bumps locked package versions (e.g., immutable, minimatch). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spelling fix Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the admin filters for both Applications and Payments to improve searchability and disambiguate certain fields when filtering across associations. It also cleans up some legacy code and clarifies parameter handling in the admin interface. The most important changes are grouped below:
Improved Filtering in Admin Interfaces
user_idfilter inapp/admin/applications.rbwith separate filters foruser_email,last_name, andfirst_name, making it easier to search applications by user details.app/admin/payments.rbto allow filtering bypayer_identity(user email), associated applicationlast_nameandfirst_name, and payment conference year (payments_conf_year). This provides more granular and user-friendly filtering options in the Payments admin.Disambiguation and Ransack Customization
payments_conf_yearinPayment, ensuring that filters on conference year are properly scoped to the payments table even when joining with associated tables.payments_conf_year.Code Cleanup and Parameter Handling
Minor Bug Fix
app/admin/applications.rbto correctly passuser_idinstead of the application object.