Conversation
…ons_conf_year for improved attribute clarity and search functionality.
…el for improved query clarity and performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the admin interface and search functionality for applications and users, mainly by correcting UI labels and enhancing how the
conf_yearattribute is handled in Ransack searches to avoid ambiguity. Additionally, it includes a minor fix to a database query and updates related tests.Admin UI improvements:
app/admin/applications.rbandapp/admin/users.rbfor consistency and professionalism.applications_conf_year), making it clearer and preventing conflicts when joining associated tables.Search and filtering enhancements:
applications_conf_yearto theApplicationmodel to disambiguate theconf_yearfield in complex searches, and included it in the list of ransackable attributes.applications_conf_yearin the expected ransackable attributes, ensuring test coverage for this change.Code quality and query improvements:
current_conference_paymentsscope in thePaymentmodel to use Arel for better query safety and clarity.