Conversation
…plications and improve application handling Refactor the dashboard to ensure that user emails are displayed when there is no current application associated with a payment. Update the logic for displaying accepted and offered applications to handle cases where the application may not respond to expected methods. Add a new request spec to validate the display of user emails in these scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of the admin dashboard by handling cases where expected associations or methods may be missing, and adds a test to ensure correct display when a payment is not linked to an application. The changes prevent errors in the dashboard and enhance the user experience for admins.
Admin dashboard robustness improvements:
Application.active_conference_applicationsmay not return objects with adisplay_namemethod, preventing potential errors.begin/rescueblock to catch and silently handleNoMethodErrorexceptions, ensuring the dashboard remains accessible even if data is incomplete.Testing:
spec/requests/admin_dashboard_spec.rb) to verify that the admin dashboard correctly displays the user's email with a message when a payment exists without a corresponding application.