Conversation
…d as decimals Updated the PaymentsController to handle whole-dollar amounts formatted like decimals in the validated_payment_amount method. Added a corresponding request spec to ensure proper redirection when valid amounts are submitted. This improves the flexibility of payment input handling.
Updated the admin dashboard to filter payments to only include special invitees, removing scholarship and other account types. Adjusted the corresponding request specs to reflect this change, ensuring accurate expectations in the response body for special invitees.
Introduced a new filter for account type in the payments admin section, allowing for selection from distinct account types. This enhances the filtering capabilities for better payment management.
Fix payment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes related to payment handling, admin dashboard filtering, and test coverage for conference-closed scenarios. The main focus is on refining the logic for special invitees, enhancing payment amount validation to support decimal-formatted inputs, and adding comprehensive request specs for the conference closed page. Additionally, test support files are updated to better control when mocks are used.
Payment handling improvements:
validated_payment_amountinPaymentsControllerto accept whole-dollar amounts formatted as decimals (e.g., "50.0" or "50.50" are now parsed as 50), improving compatibility with external systems and database values.Admin dashboard and filtering:
account_typeof "special", excluding "scholarship" and other types. Related test expectations were updated accordingly. [1] [2] [3]account_typein the admin payments index, allowing admins to filter payments by account type.Test coverage and support improvements:
real_application_settings), enabling tests to use real database rows when necessary. [1] [2]