Conversation
Updated the applications request spec to include a test for the last sent timestamp of balance due emails. Modified the dashboard to display the last sent date, and ensured the applications controller updates the timestamp when emails are sent. This improves tracking of email notifications for balance dues.
Bumped ActiveRecord schema version to 7.2 and added new columns to the active_storage_blobs and applications tables. Introduced service_name to active_storage_blobs and balance_due_emails_last_sent_at to applications. Also added the active_storage_variant_records table with necessary foreign keys for improved data integrity and functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds tracking for when balance due emails are sent to applicants, displaying this information in the admin dashboard and persisting it in the database. It includes a database migration, updates to the admin UI, controller logic, and relevant tests.
Database changes:
balance_due_emails_last_sent_atdatetime column to theapplication_settingstable to store the timestamp of the last sent balance due email. [1] [2]Admin dashboard improvements:
dashboard.rb) to display the last sent time for balance due emails, showing either the formatted timestamp or 'never' if no email has been sent.Controller logic:
send_balance_dueaction to update thebalance_due_emails_last_sent_atfield whenever balance due emails are sent.Testing enhancements:
balance_due_emails_last_sent_atfield is correctly set after sending emails, and improved test setup for application settings. [1] [2] [3]Schema updates:
db/schema.rbto reflect the new column and related database structure changes. [1] [2] [3]