Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
eb33a65
Bump rack from 3.1.14 to 3.1.16 in the bundler group across 1 directory
dependabot[bot] Jun 5, 2025
4f8021b
Remove unused address building logic in ProfilesController
rsmoke Jun 5, 2025
0f3058d
Remove AddressCopyController and its registration from Stimulus appli…
rsmoke Jun 5, 2025
255ad39
Remove Address and AddressType models along with their associated logic
rsmoke Jun 5, 2025
375de2e
Remove AddressPolicy class to streamline authorization logic
rsmoke Jun 5, 2025
cd472ae
Refactor Profile model by removing address associations and validations
rsmoke Jun 5, 2025
e339d20
Refactor profile form by removing address fields and associated logic
rsmoke Jun 5, 2025
b3069aa
Refactor profile summary view to enhance layout and maintainability
rsmoke Jun 5, 2025
fc2a5ff
Refactor profile view to improve layout and clarity
rsmoke Jun 5, 2025
bef7085
Remove address-related tables and columns from the database schema
rsmoke Jun 5, 2025
133c85b
Remove address seeding logic from db/seeds.rb
rsmoke Jun 5, 2025
d59dba8
Update sample data task to create development data
rsmoke Jun 5, 2025
69b8e64
Remove address-related factories and specs to streamline test suite
rsmoke Jun 5, 2025
d4fa586
Refactor profile factory by removing address associations
rsmoke Jun 5, 2025
2b8d6c4
Refactor profile specs to remove address-related tests
rsmoke Jun 5, 2025
635aea7
Refactor profile policy specs to remove address-related references
rsmoke Jun 5, 2025
8100736
Refactor user creation helpers to remove address-related attributes
rsmoke Jun 5, 2025
a18d5c8
Merge pull request #138 from lsa-mis/LRA-1113-evaluate-remove-address…
rsmoke Jun 5, 2025
dab71a2
Merge pull request #137 from lsa-mis/dependabot/bundler/bundler-b051e…
rsmoke Jun 5, 2025
ca91795
Refactor contest descriptions helper to enhance instance summary display
rsmoke Jun 9, 2025
3e3c1af
Update contest descriptions table header for clarity
rsmoke Jun 9, 2025
0a6f43a
Refactor contest descriptions helper to simplify total instances display
rsmoke Jun 9, 2025
011b2aa
Update eligibility rules display in containers helper for improved re…
rsmoke Jun 10, 2025
489e7a5
Enhance contest descriptions table for improved readability
rsmoke Jun 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ GEM
rspec-mocks (~> 3.12)
rspec-support (~> 3.12)
racc (1.8.1)
rack (3.1.14)
rack (3.1.16)
rack-accept (0.4.5)
rack (>= 0.4)
rack-protection (4.1.1)
Expand Down
6 changes: 1 addition & 5 deletions app/controllers/profiles_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ def new
Rails.logger.debug { "^^^^^^^^^^^^^^^^ Profile is nil for user: #{current_user.inspect}" }
else
authorize @profile
@profile.build_home_address
@profile.build_campus_address
end
end

Expand Down Expand Up @@ -86,8 +84,6 @@ def profile_params
:major,
:department, :grad_date, :degree, :receiving_financial_aid,
:accepted_financial_aid_notice, :financial_aid_description,
:hometown_publication, :pen_name,
home_address_attributes: %i[id address1 address2 city state zip country address_type_id],
campus_address_attributes: %i[id address1 address2 city state zip country address_type_id])
:hometown_publication, :pen_name)
end
end
4 changes: 2 additions & 2 deletions app/helpers/containers_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ def render_eligibility_rules(description)
eligibility_plain = description.eligibility_rules.to_plain_text
if eligibility_plain.length > 100
content_tag(:div) do
truncate(eligibility_plain, length: 100, omission: '') +
link_to('...more', '#',
truncate(eligibility_plain, length: 60, omission: '') +
link_to(' ...more', '#',
data: {
action: 'click->modal#open',
url: eligibility_rules_container_contest_description_path(description.container, description),
Expand Down
5 changes: 2 additions & 3 deletions app/helpers/contest_descriptions_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ def contest_description_summary(description)
if active_instances.any?
first_active = active_instances.first
entry_count = first_active.entries.where(deleted: false).count
summary += '<small class="text-nowrap">Active instance</small><br>'
summary += link_to(pluralize(entry_count, 'entry'),
container_contest_description_contest_instance_path(description.container, description, first_active), class: 'btn btn-sm btn-primary')
summary += link_to("Active: #{pluralize(entry_count, 'entry')}",
container_contest_description_contest_instance_path(description.container, description, first_active), class: 'btn btn-sm btn-primary small')
summary += '<br>'
end
summary += "<small>#{pluralize(total_instances, 'instance')}</small>"
Expand Down
17 changes: 0 additions & 17 deletions app/javascript/controllers/address_copy_controller.js

This file was deleted.

3 changes: 0 additions & 3 deletions app/javascript/controllers/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@

import { application } from "./application"

import AddressCopyController from "./address_copy_controller"
application.register("address-copy", AddressCopyController)

import CharacterCounterController from "./character_counter_controller"
application.register("character-counter", CharacterCounterController)

Expand Down
108 changes: 0 additions & 108 deletions app/models/address.rb

This file was deleted.

19 changes: 0 additions & 19 deletions app/models/address_type.rb

This file was deleted.

41 changes: 13 additions & 28 deletions app/models/profile.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,34 +20,28 @@
# umid :string(255)
# created_at :datetime not null
# updated_at :datetime not null
# campus_address_id :bigint
# campus_id :bigint
# class_level_id :bigint
# home_address_id :bigint
# school_id :bigint
# user_id :bigint not null
#
# Indexes
#
# campus_id_idx (campus_id)
# class_level_id_idx (class_level_id)
# id_unq_idx (id) UNIQUE
# index_profiles_on_campus_address_id (campus_address_id)
# index_profiles_on_campus_id (campus_id)
# index_profiles_on_class_level_id (class_level_id)
# index_profiles_on_home_address_id (home_address_id)
# index_profiles_on_school_id (school_id)
# index_profiles_on_umid (umid) UNIQUE
# index_profiles_on_user_id (user_id)
# school_id_idx (school_id)
# user_id_idx (user_id)
# campus_id_idx (campus_id)
# class_level_id_idx (class_level_id)
# id_unq_idx (id) UNIQUE
# index_profiles_on_campus_id (campus_id)
# index_profiles_on_class_level_id (class_level_id)
# index_profiles_on_school_id (school_id)
# index_profiles_on_umid (umid) UNIQUE
# index_profiles_on_user_id (user_id)
# school_id_idx (school_id)
# user_id_idx (user_id)
#
# Foreign Keys
#
# fk_rails_... (campus_address_id => addresses.id)
# fk_rails_... (campus_id => campuses.id)
# fk_rails_... (class_level_id => class_levels.id)
# fk_rails_... (home_address_id => addresses.id)
# fk_rails_... (school_id => schools.id)
# fk_rails_... (user_id => users.id)
#
Expand All @@ -60,17 +54,11 @@ class Profile < ApplicationRecord
belongs_to :campus, optional: true
has_many :entries, dependent: :restrict_with_error

belongs_to :home_address, class_name: 'Address', optional: true
belongs_to :campus_address, class_name: 'Address', optional: true

accepts_nested_attributes_for :home_address, allow_destroy: true
accepts_nested_attributes_for :campus_address, allow_destroy: true

validates :preferred_first_name, presence: true, length: { in: 1..255 }
validates :preferred_last_name, presence: true, length: { in: 1..255 }
validates :umid,
presence: true,
uniqueness: true,
validates :umid,
presence: true,
uniqueness: true,
length: { is: 8 },
format: { with: /\A\d{8}\z/, message: "must be exactly 8 digits" }
validates :grad_date, presence: true
Expand All @@ -79,9 +67,6 @@ class Profile < ApplicationRecord
validates :class_level_id, presence: true
validates :campus_id, presence: true
validates :school_id, presence: true
validates :home_address, presence: true
validates :campus_address, presence: true


def display_name
"#{preferred_first_name} #{preferred_last_name}"
Expand Down
50 changes: 0 additions & 50 deletions app/policies/address_policy.rb

This file was deleted.

Loading
Loading